Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r153137292
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,23 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
-def _merge_type(a, b):
+def _merge_type(a, b, path=''):
--- End diff --
I prefer the format we can know the path to the error and I guess we don't
need the pretty one like the `printSchema()`.
Maybe following the #18521 format is good enough, and the current one is
good as well but I wanted something in front of the path string instead of
starting with `.`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
