Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r153530156
--- Diff:
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
---
@@ -86,6 +86,8 @@ class SubmitRestProtocolSuite extends SparkFunSuite {
message.clientSparkVersion = "1.2.3"
message.appResource = "honey-walnut-cherry.jar"
message.mainClass = "org.apache.spark.examples.SparkPie"
+ message.appArgs = Array("hdfs://tmp/auth")
+ message.environmentVariables = Map("SPARK_HOME" -> "/test")
--- End diff --
@Gschiavon You're right, I didn't see those variables were already set
below. But, I do have a question now about whether these fields are optional or
not. In the original test, (L.93), there's a comment about "optional fields",
and the app args and env vars are tested there (L.105-106). Since this test was
added with Standalone mode in mind, I wonder if these fields are considered
optional there? There's no documentation as you said so we can't know for sure.
I just want to make sure the extra validation doesn't break any existing
applications (in Standalone cluster mode).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
