Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r153824692
--- Diff:
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
---
@@ -86,6 +86,8 @@ class SubmitRestProtocolSuite extends SparkFunSuite {
message.clientSparkVersion = "1.2.3"
message.appResource = "honey-walnut-cherry.jar"
message.mainClass = "org.apache.spark.examples.SparkPie"
+ message.appArgs = Array("hdfs://tmp/auth")
+ message.environmentVariables = Map("SPARK_HOME" -> "/test")
--- End diff --
OK, I was looking at RestSubmissionClient (used by Mesos and Standalone) -
the client does always set 'appArgs' and 'envrionmentVariables':
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/deploy/rest/RestSubmissionClient.scala#L427
So, it's only a bug when the user does not use the RestSubmissionClient (by
using 'curl' directly to the server, for example). So, that addresses my
concern about Standalone mode. As to whether to add a similar check in the
Standalone class, I don't have a strong opinion about it (fix it here or fix in
another PR).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
