Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/19981
  
    > Those are not being installed with this interface, are they?
    
    We are going to, right? Otherwise creating the interface just for SQL 
doesn't align with your goal to centralize this part.
    
    > But I really don't think going back to the previous way is the right 
thing.
    
    I do think the previous code is cleaner than the current one. This may due 
to personal tastes so need more feedback from other people.
    
    > The listener is now being installed before it was before (when the 
context starts, instead of later), so it's less likely that it will miss events.
    
    I'm talking about not catching event if users are not using SQL functions. 
Again this is an internal behavior change that can affect Spark event catching 
logic inside SQL listener, which may be added in the future. I'm not saying we 
can't change it, but with a proper reason.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to