Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157134291
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusStore.scala
---
@@ -25,21 +25,17 @@ import scala.collection.mutable.ArrayBuffer
import com.fasterxml.jackson.databind.annotation.JsonDeserialize
-import org.apache.spark.{JobExecutionStatus, SparkConf}
-import org.apache.spark.scheduler.SparkListener
-import org.apache.spark.status.AppStatusPlugin
+import org.apache.spark.JobExecutionStatus
import org.apache.spark.status.KVUtils.KVIndexParam
-import org.apache.spark.ui.SparkUI
-import org.apache.spark.util.Utils
import org.apache.spark.util.kvstore.KVStore
/**
* Provides a view of a KVStore with methods that make it easy to query
SQL-specific state. There's
* no state kept in this class, so it's ok to have multiple instances of
it in an application.
*/
-private[sql] class SQLAppStatusStore(
+class SQLAppStatusStore(
--- End diff --
Following the existing convention, classes under the `execution` package
are meant to be private and doesn't need the `private[sql]`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
