Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19977#discussion_r157936581
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
 ---
    @@ -566,6 +568,21 @@ object TypeCoercion {
         }
       }
     
    +  /**
    +   * When all inputs in [[Concat]] are binary, coerces an output type to 
binary
    +   */
    +  case class ConcatCoercion(conf: SQLConf) extends TypeCoercionRule {
    +    override protected def coerceTypes(
    +        plan: LogicalPlan): LogicalPlan = plan transformExpressionsUp {
    --- End diff --
    
    This is in the big batch of analyzer rules: `Batch("Resolution")`. This 
rule will be executed without the stop condition. 
    
    cc @cloud-fan Should we do it in `Batch("Finish Analysis")`? Any better 
idea?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to