Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19977#discussion_r157940334
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/ByteArray.java ---
@@ -74,4 +74,29 @@ public static long getPrefix(byte[] bytes) {
}
return Arrays.copyOfRange(bytes, start, end);
}
+
+ public static byte[] concat(byte[]... inputs) {
+ // Compute the total length of the result
+ int totalLength = 0;
+ for (int i = 0; i < inputs.length; i++) {
+ if (inputs[i] != null) {
+ totalLength += inputs[i].length;
+ } else {
+ return null;
+ }
+ }
+
+ // Allocate a new byte array, and copy the inputs one by one into it
+ final byte[] result = new byte[totalLength];
+ int offset = 0;
+ for (int i = 0; i < inputs.length; i++) {
+ int len = inputs[i].length;
--- End diff --
null check here too?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
