Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19977#discussion_r157943490
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
 ---
    @@ -566,6 +568,21 @@ object TypeCoercion {
         }
       }
     
    +  /**
    +   * When all inputs in [[Concat]] are binary, coerces an output type to 
binary
    +   */
    +  case class ConcatCoercion(conf: SQLConf) extends TypeCoercionRule {
    --- End diff --
    
    Aha, sounds reasonable. I feel we should fix that in an separate pr first, 
thought? Or, this pr should include the fix, too?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to