Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r159099688
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -137,18 +137,10 @@ final class Bucketizer @Since("1.4.0")
(@Since("1.4.0") override val uid: String
/**
* Determines whether this `Bucketizer` is going to map multiple
columns. If and only if
* `inputCols` is set, it will map multiple columns. Otherwise, it just
maps a column specified
- * by `inputCol`. A warning will be printed if both are set.
+ * by `inputCol`.
*/
private[feature] def isBucketizeMultipleColumns(): Boolean = {
- if (isSet(inputCols) && isSet(inputCol)) {
- logWarning("Both `inputCol` and `inputCols` are set, we ignore
`inputCols` and this " +
- "`Bucketizer` only map one column specified by `inputCol`")
- false
- } else if (isSet(inputCols)) {
- true
- } else {
- false
- }
+ isSet(inputCols)
--- End diff --
Seems superfluous to how have a separate method for this
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
