Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19993#discussion_r159100299
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/feature/BucketizerSuite.scala ---
    @@ -401,15 +401,9 @@ class BucketizerSuite extends SparkFunSuite with 
MLlibTestSparkContext with Defa
         }
       }
     
    -  test("Both inputCol and inputCols are set") {
    -    val bucket = new Bucketizer()
    -      .setInputCol("feature1")
    -      .setOutputCol("result")
    -      .setSplits(Array(-0.5, 0.0, 0.5))
    -      .setInputCols(Array("feature1", "feature2"))
    -
    -    // When both are set, we ignore `inputCols` and just map the column 
specified by `inputCol`.
    -    assert(bucket.isBucketizeMultipleColumns() == false)
    +  test("assert exception is thrown is both multi-column and single-column 
params are set") {
    --- End diff --
    
    "is thrown is both" -> "is thrown if both"


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to