Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19943#discussion_r159222649
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
 ---
    @@ -139,15 +146,25 @@ class OrcFileFormat
           }
         }
     
    +    val resultSchema = StructType(requiredSchema.fields ++ 
partitionSchema.fields)
    +    val enableVectorizedReader = 
sparkSession.sessionState.conf.orcVectorizedReaderEnabled &&
    +      supportBatch(sparkSession, resultSchema)
    --- End diff --
    
    `supportBatch` already have the condition 
`conf.orcVectorizedReaderEnabled`, I think here we can just write
    ```
    val enableVectorizedReader = supportBatch(sparkSession, resultSchema)
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to