Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19943#discussion_r160069456
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -386,6 +386,16 @@ object SQLConf {
.checkValues(Set("hive", "native"))
.createWithDefault("native")
+ val ORC_VECTORIZED_READER_ENABLED =
buildConf("spark.sql.orc.enableVectorizedReader")
+ .doc("Enables vectorized orc decoding.")
+ .booleanConf
+ .createWithDefault(true)
+
+ val ORC_VECTORIZED_JAVA_READER_ENABLED =
buildConf("spark.sql.orc.enableVectorizedJavaReader")
--- End diff --
We should have only one implementation. Since you already implemented in
java, let's drop the scala one.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
