Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20200#discussion_r160391233
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -985,7 +985,7 @@ abstract class RDD[T: ClassTag](
def subtract(
other: RDD[T],
p: Partitioner)(implicit ord: Ordering[T] = null): RDD[T] =
withScope {
- if (partitioner == Some(p)) {
+ if (partitioner.contains(p)) {
--- End diff --
Actually I think the previous code is more readable.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
