Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20200#discussion_r160391487 --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala --- @@ -1345,13 +1346,12 @@ abstract class RDD[T: ClassTag]( if (buf.isEmpty) { numPartsToTry = partsScanned * scaleUpFactor } else { - // the left side of max is >=1 whenever partsScanned >= 2 - numPartsToTry = Math.max((1.5 * num * partsScanned / buf.size).toInt - partsScanned, 1) + // As left > 0, numPartsToTry is always >= 1 --- End diff -- This is the same a s SparkPlan. executeTake(). Should we also fix that?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org