Github user gengliangwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20223#discussion_r160991236
  
    --- Diff: 
launcher/src/main/java/org/apache/spark/launcher/AbstractAppHandle.java ---
    @@ -71,15 +71,16 @@ public void stop() {
       @Override
       public synchronized void disconnect() {
         if (!disposed) {
    --- End diff --
    
    `if(!isDisposed())` ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to