Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/20223#discussion_r160989105 --- Diff: launcher/src/main/java/org/apache/spark/launcher/AbstractAppHandle.java --- @@ -91,10 +92,15 @@ LauncherConnection getConnection() { return connection; } - boolean isDisposed() { + synchronized boolean isDisposed() { return disposed; } + synchronized void markDisposed() { --- End diff -- why do we need `synchronized` here?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org