Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20249#discussion_r161477649
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -800,6 +802,15 @@ case class AlterTableSetLocationCommand(
CommandUtils.updateTableStats(sparkSession, table)
Seq.empty[Row]
}
+
+ private def updatePathInProps(
+ storage: CatalogStorageFormat,
+ newPath: Option[String]): Map[String, String] = {
--- End diff --
I would suggest to use String as type for newPath instead of Option[String]
as updatePathInProps is always called with an Some so Option is not needed here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
