Github user attilapiros commented on a diff in the pull request: https://github.com/apache/spark/pull/20249#discussion_r161491069 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -751,6 +751,25 @@ class HiveDDLSuite } } + test("SPARK-23057: SET LOCATION should change the path of partition in table") { + withTable("boxes") { + sql("CREATE TABLE boxes (height INT, length INT) PARTITIONED BY (width INT)") + sql("INSERT OVERWRITE TABLE boxes PARTITION (width=4) SELECT 4, 4") + val expected = "/path/to/part/ways" + sql(s"ALTER TABLE boxes PARTITION (width=4) SET LOCATION '$expected'") + val catalog = spark.sessionState.catalog --- End diff -- This is close to the method body checkPath(). Is it possible to find a common place for the method and call the method from here too? Like creating an object close the DDLSuite. What is your opinion?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org