Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20023#discussion_r162052779
  
    --- Diff: sql/core/src/test/resources/sql-tests/inputs/decimals.sql ---
    @@ -0,0 +1,53 @@
    +--
    +--   Licensed to the Apache Software Foundation (ASF) under one or more
    +--   contributor license agreements.  See the NOTICE file distributed with
    +--   this work for additional information regarding copyright ownership.
    +--   The ASF licenses this file to You under the Apache License, Version 
2.0
    +--   (the "License"); you may not use this file except in compliance with
    +--   the License.  You may obtain a copy of the License at
    +--
    +--      http://www.apache.org/licenses/LICENSE-2.0
    +--
    +--   Unless required by applicable law or agreed to in writing, software
    +--   distributed under the License is distributed on an "AS IS" BASIS,
    +--   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
    +--   See the License for the specific language governing permissions and
    +--   limitations under the License.
    +--
    +
    +-- tests for decimals handling in operations
    --- End diff --
    
    that file is under `.../typeCoercion/native/`, which is meant for the 
default behavior(native mode of type coercion). If we introduce a sql2001 mode, 
we will put a same file under `.../typeCoercion/sql2001/`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to