Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20023#discussion_r161829582
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala ---
@@ -136,10 +137,52 @@ object DecimalType extends AbstractDataType {
case DoubleType => DoubleDecimal
}
+ private[sql] def forLiteral(literal: Literal): DecimalType =
literal.value match {
+ case v: Short => fromBigDecimal(BigDecimal(v))
+ case v: Int => fromBigDecimal(BigDecimal(v))
+ case v: Long => fromBigDecimal(BigDecimal(v))
+ case _ => forType(literal.dataType)
--- End diff --
this problem was present before this PR. Should we fix it here? Is this fix
needed? I guess that if it would have been a problem, it would already have
been reported.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
