Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2860#discussion_r19099520
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnStats.scala ---
    @@ -24,11 +24,13 @@ import 
org.apache.spark.sql.catalyst.expressions.{AttributeMap, Attribute, Attri
     import org.apache.spark.sql.catalyst.types._
     
     private[sql] class ColumnStatisticsSchema(a: Attribute) extends 
Serializable {
    -  val upperBound = AttributeReference(a.name + ".upperBound", a.dataType, 
nullable = false)()
    -  val lowerBound = AttributeReference(a.name + ".lowerBound", a.dataType, 
nullable = false)()
    -  val nullCount =  AttributeReference(a.name + ".nullCount", IntegerType, 
nullable = false)()
    +  val upperBound = AttributeReference(a.name + ".upperBound", a.dataType, 
nullable = true)()
    +  val lowerBound = AttributeReference(a.name + ".lowerBound", a.dataType, 
nullable = true)()
    --- End diff --
    
    Upper/lower bound can be null for types like string.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to