Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2860#discussion_r19099771
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnStats.scala ---
@@ -185,15 +196,16 @@ private[sql] class StringColumnStats extends
ColumnStats {
} else {
nullCount += 1
}
+ count += 1
+ sizeInBytes += STRING.actualSize(row, ordinal)
--- End diff --
This can potentially slow down caching process of string columns, because
the `.getBytes("utf-8")` call within `actualSize` traverses the whole string.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
