Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/19993#discussion_r162717263 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala --- @@ -166,6 +167,8 @@ private[ml] object Param { @DeveloperApi object ParamValidators { + private val LOGGER = LoggerFactory.getLogger(ParamValidators.getClass) --- End diff -- Let's switch this to use the Logging trait, to match other MLlib patterns.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org