Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r162719519
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -201,9 +184,13 @@ final class Bucketizer @Since("1.4.0")
(@Since("1.4.0") override val uid: String
@Since("1.4.0")
override def transformSchema(schema: StructType): StructType = {
- if (isBucketizeMultipleColumns()) {
+ ParamValidators.checkExclusiveParams(this, "inputCol", "inputCols")
--- End diff --
my initial implementation (with @hhbyyh's comments) was more generic and
checked what you said. After, @MLnick and @viirya asked to switch to a more
generic approach which is the current you see. I'm fine with either of those,
but I think we need to choose one way and go in that direction, otherwise we
just loose time.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
