Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20224#discussion_r163748166
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -325,6 +326,28 @@ object WholeStageCodegenExec {
}
}
+object WholeStageCodegenId {
+ private val codegenStageCounter = ThreadLocal.withInitial(new
Supplier[Integer] {
+ override def get() = 0 // TODO: change to Scala lambda syntax when
upgraded to Scala 2.12+
--- End diff --
shall we just use 1 as initial value and add a comment to say that 0 is
preserved for temporary WholeStageCodegenExec objects? Then we only need a
`reset` method.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
