Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20224#discussion_r163767104
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -629,6 +629,13 @@ object SQLConf {
         .booleanConf
         .createWithDefault(true)
     
    +  val WHOLESTAGE_CODEGEN_USE_ID_IN_CLASS_NAME =
    +    buildConf("spark.sql.codegen.wholeStage.useIdInClassName")
    --- End diff --
    
    Logically it's better to have the `wholeStage` prefix, let's start from 
here that always adding `wholeStage` prefix to whole stage related config.(keep 
the existing one unchanged)
    
    cc @viirya 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to