Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2906#issuecomment-60268305
I just gave this a quick read-through, and the structure makes sense. I
left several small comments. I see the chunks of logic I would expect, but did
not evaluate it in detail. The existence of some tests suggests this probably
basically works :) I am wondering about performance too as this relies on Scala
idioms in many places; it might be worth a quick look with jprofiler if you can
to see if there are any easy-win optimizations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
