Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/2906#issuecomment-60463744
@yu-iskw I added you to the whitelist. Future commits from you should
trigger Jenkins automatically. Just took a very brief scan over the code and
really appreciate the fact that more than half of the code is doc/test/example.
I will check the implementation after the feature freeze. Some high-level
questions for now:
1. Is there a paper that you used as reference? If so, please cite it in
the doc.
2. Could you send some performance testing results on dense and sparse
datasets?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
