Github user koeninger commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20572#discussion_r169538019
  
    --- Diff: 
external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/CachedKafkaConsumer.scala
 ---
    @@ -53,7 +51,7 @@ class CachedKafkaConsumer[K, V] private(
     
       // TODO if the buffer was kept around as a random-access structure,
       // could possibly optimize re-calculating of an RDD in the same batch
    -  protected var buffer = ju.Collections.emptyList[ConsumerRecord[K, 
V]]().iterator
    +  protected var buffer = 
ju.Collections.emptyListIterator[ConsumerRecord[K, V]]()
    --- End diff --
    
    Agreed, think it should be ok


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to