Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20572#discussion_r170278317
  
    --- Diff: 
external/kafka-0-10/src/test/scala/org/apache/spark/streaming/kafka010/KafkaTestUtils.scala
 ---
    @@ -162,17 +162,22 @@ private[kafka010] class KafkaTestUtils extends 
Logging {
       }
     
       /** Create a Kafka topic and wait until it is propagated to the whole 
cluster */
    -  def createTopic(topic: String, partitions: Int): Unit = {
    -    AdminUtils.createTopic(zkUtils, topic, partitions, 1)
    +  def createTopic(topic: String, partitions: Int, config: Properties): 
Unit = {
    +    AdminUtils.createTopic(zkUtils, topic, partitions, 1, config)
         // wait until metadata is propagated
         (0 until partitions).foreach { p =>
           waitUntilMetadataIsPropagated(topic, p)
         }
       }
     
    +  /** Create a Kafka topic and wait until it is propagated to the whole 
cluster */
    +  def createTopic(topic: String, partitions: Int): Unit = {
    +    createTopic(topic, partitions, new Properties)
    +  }
    +
       /** Create a Kafka topic and wait until it is propagated to the whole 
cluster */
       def createTopic(topic: String): Unit = {
    -    createTopic(topic, 1)
    +    createTopic(topic, 1, new Properties)
    --- End diff --
    
    Nit: `new Properties()`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to