Github user retronym commented on a diff in the pull request:
https://github.com/apache/spark/pull/2615#discussion_r19324410
--- Diff: bin/compute-classpath.sh ---
@@ -20,7 +20,7 @@
# This script computes Spark's classpath and prints it to stdout; it's
used by both the "run"
# script and the ExecutorRunner in standalone cluster mode.
-SCALA_VERSION=2.10
+SCALA_VERSION=${SCALA_VERSION:-"2.10"}
--- End diff --
Arguably, if you are picking this up from the environment, you should call
it `SPARK_SCALA_VERSION`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
