Github user ScrapCodes commented on a diff in the pull request: https://github.com/apache/spark/pull/2615#discussion_r19324476 --- Diff: bin/compute-classpath.sh --- @@ -36,6 +34,18 @@ else CLASSPATH="$CLASSPATH:$FWDIR/conf" fi +if [ -z "$SCALA_VERSION" ]; then --- End diff -- SCALA_VERSION is here for historical reasons. @pwendell Should we change this to SPARK_SCALA_VERSION as part of this patch, as @retronym suggested ?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org