Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20692#discussion_r171624644
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -106,7 +106,7 @@ abstract class Attribute extends LeafExpression with
NamedExpression with NullIn
override def toAttribute: Attribute = this
def newInstance(): Attribute
-
+ def stringWithType: String = s"$toString: ${dataType.simpleString}"
--- End diff --
Nit: the `:` isn't needed and will accumulate to quite a few extra
characters in plans. SQL uses `(id bigint, data string)` without `:` so I think
we should mirror that.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
