Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20692#discussion_r171630852
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
---
@@ -94,7 +94,7 @@ case class CreateHiveTableAsSelectCommand(
Seq.empty[Row]
}
- override def argString: String = {
+ override def argString(isLeaf: Boolean): String = {
--- End diff --
thanks, you are right. I won't change the current implementation, since if
we need to change behavior according to a flag (for instance if we decide to
add the info only if the extended mode is set) these changes are needed. If
not, I will follow this comment, thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
