Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20700#discussion_r171774915
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -833,8 +669,8 @@ class CodegenContext {
} else if ($isNullB) {
return 1;
} else {
- ${javaType(elementType)} $elementA = ${getValue("a",
elementType, "i")};
- ${javaType(elementType)} $elementB = ${getValue("b",
elementType, "i")};
+ $jt $elementA = ${CodeGenerator.getValue("a", elementType,
"i")};
+ $jt $elementB = ${CodeGenerator.getValue("b", elementType,
"i")};
--- End diff --
Inside `CodegenContext`, I think we can just do `import CodeGenerator._`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
