Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20700#discussion_r171773544
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -537,13 +537,38 @@ class CodegenContext {
extraClasses.append(code)
}
- final val JAVA_BOOLEAN = "boolean"
- final val JAVA_BYTE = "byte"
- final val JAVA_SHORT = "short"
- final val JAVA_INT = "int"
- final val JAVA_LONG = "long"
- final val JAVA_FLOAT = "float"
- final val JAVA_DOUBLE = "double"
+ /**
+ * Returns true if the Java type has a special accessor and setter in
[[InternalRow]].
--- End diff --
This comment is copied. But seems not totally correct. `InternalRow` also
has special accessor for `Decimal`. But it is not a primitive type here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
