Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20736#discussion_r172191654
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
---
@@ -66,4 +66,16 @@ class ObjectExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
checkEvalutionWithUnsafeProjection(
mapEncoder.serializer.head, mapExpected, mapInputRow)
}
+
+ test("SPARK-23586: UnwrapOption should support interpreted execution") {
--- End diff --
I just found out that there are literally no unit tests for this expression
:(...
Can you use `checkEvaluation`? This will make sure both code gen and
interpreted mode are tested?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
