Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20736#discussion_r172194194
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
 ---
    @@ -382,8 +382,14 @@ case class UnwrapOption(
     
       override def inputTypes: Seq[AbstractDataType] = ObjectType :: Nil
     
    -  override def eval(input: InternalRow): Any =
    -    throw new UnsupportedOperationException("Only code-generated 
evaluation is supported")
    +  override def eval(input: InternalRow): Any = {
    +    val inputObject = child.eval(input)
    --- End diff --
    
    I am fine either way. This is going to be slow anyway. Let's leave as it is.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to