Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20807#discussion_r174035432
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
 ---
    @@ -496,7 +497,7 @@ private[yarn] class YarnAllocator(
           executorIdCounter += 1
           val executorHostname = container.getNodeId.getHost
           val containerId = container.getId
    -      val executorId = executorIdCounter.toString
    +      val executorId = (initialExecutorIdCounter + 
executorIdCounter).toString
    --- End diff --
    
    I get the point of fix. But also it seems a little strange to me. 
    
    Besides, do we really need to fix your issue? As I know the case here is 
not a normal one.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to