Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20701#discussion_r175235205
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala ---
    @@ -312,4 +312,5 @@ class BisectingKMeansSummary private[clustering] (
         predictions: DataFrame,
         predictionCol: String,
         featuresCol: String,
    -    k: Int) extends ClusteringSummary(predictions, predictionCol, 
featuresCol, k)
    +    k: Int,
    +    numIter: Int) extends ClusteringSummary(predictions, predictionCol, 
featuresCol, k, numIter)
    --- End diff --
    
    Here (and in the others), we should add this as param in the comment above 
as done with the other params


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to