Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20701#discussion_r175292115
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeansModel.scala ---
@@ -36,8 +36,9 @@ import org.apache.spark.sql.{Row, SparkSession}
* A clustering model for K-means. Each point belongs to the cluster with
the closest center.
*/
@Since("0.8.0")
-class KMeansModel @Since("2.4.0") (@Since("1.0.0") val clusterCenters:
Array[Vector],
- @Since("2.4.0") val distanceMeasure: String)
+class KMeansModel private[spark] (@Since("1.0.0") val clusterCenters:
Array[Vector],
--- End diff --
I just didn't want the user to be able to create a KMeansModel setting the
number of iterations. I moved the other constructor which is still available. I
don't have strong reasons against making this public, so I am removing the
private clause if you think we best let it to be public.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
