Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r182520090
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilderSuite.scala
---
@@ -89,6 +97,29 @@ class KubernetesDriverBuilderSuite extends SparkFunSuite
{
SECRETS_STEP_TYPE)
}
+ test("Apply Python step if main resource is python.") {
+ val conf = KubernetesConf(
--- End diff --
Unrelated to this PR, but @mccheah, should we have something like the
fluent/builder pattern here for `KubernetesConf` since it's grown to quite a
few params. I'm happy to take a stab at it if we agree that's a good direction.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
