Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r182567225
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesExecutorBuilder.scala
---
@@ -29,9 +30,11 @@ private[spark] class KubernetesExecutorBuilder(
def buildFromFeatures(
kubernetesConf: KubernetesConf[KubernetesExecutorSpecificConf]):
SparkPod = {
val baseFeatures = Seq(provideBasicStep(kubernetesConf))
- val allFeatures = if
(kubernetesConf.roleSecretNamesToMountPaths.nonEmpty) {
- baseFeatures ++ Seq(provideSecretsStep(kubernetesConf))
- } else baseFeatures
+ val maybeRoleSecretNamesStep = if
(kubernetesConf.roleSecretNamesToMountPaths.nonEmpty) {
+ Some(provideSecretsStep(kubernetesConf)) } else None
+ val allFeatures: Seq[KubernetesFeatureConfigStep] =
--- End diff --
No, but there will be more features and I thought that doing options in the
description of `allFeatures` was cleaner
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
