Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r183155443
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -54,7 +54,7 @@ private[spark] class BasicExecutorFeatureStep(
private val memoryOverheadMiB = kubernetesConf
.get(EXECUTOR_MEMORY_OVERHEAD)
- .getOrElse(math.max((MEMORY_OVERHEAD_FACTOR * executorMemoryMiB).toInt,
+ .getOrElse(math.max((kubernetesConf.get(MEMORY_OVERHEAD_FACTOR) *
executorMemoryMiB).toInt,
--- End diff --
So this won't allow people to set a lower overhead than
MEMORY_OVERHEAD_MIN_MIB, is that the goal?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
