Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21088#discussion_r184543396
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -892,7 +892,8 @@ private[spark] class Client(
// Include driver-specific java options if we are launching a driver
if (isClusterMode) {
sparkConf.get(DRIVER_JAVA_OPTIONS).foreach { opts =>
- javaOpts ++=
Utils.splitCommandString(opts).map(YarnSparkHadoopUtil.escapeForShell)
+ javaOpts ++= Utils.splitCommandString(Utils.substituteAppId(opts,
appId.toString))
--- End diff --
I'd prefer:
```
Utils.splitCommandString(opts)
.map(Utils.substituteAppId(...))
.map(YarnSparkHadoopUtil.escapeForShell)
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
