Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21088#discussion_r184543613
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/worker/ExecutorRunner.scala ---
    @@ -142,7 +142,11 @@ private[deploy] class ExecutorRunner(
       private def fetchAndRunExecutor() {
         try {
           // Launch the process
    -      val builder = CommandUtils.buildProcessBuilder(appDesc.command, new 
SecurityManager(conf),
    +      val subsOpts = appDesc.command.javaOpts.map {
    +        opt => Utils.substituteAppNExecIds(opt, appId, execId.toString)
    --- End diff --
    
    nit: `opt =>` goes in previous line


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to