Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21123#discussion_r185055954
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -213,6 +215,26 @@ case class DataSourceAnalysis(conf: SQLConf) extends
Rule[LogicalPlan] with Cast
}
}
+/**
+ * Replace the V2 data source of table in [[InsertIntoTable]] to V1
[[FileFormat]].
+ * E.g, with temporary view `t` using [[FileDataSourceV2]], inserting into
view `t` fails
+ * since there is no correspoding physical plan.
+ * This is a temporary hack for making current data source V2 work.
--- End diff --
I don't like the idea of "temporary hack" rules. What is the long-term plan
for getting rid of this? Or is this something we will end up supporting forever?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
