Github user gengliangwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21123#discussion_r185215070
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
 ---
    @@ -213,6 +215,26 @@ case class DataSourceAnalysis(conf: SQLConf) extends 
Rule[LogicalPlan] with Cast
       }
     }
     
    +/**
    + * Replace the V2 data source of table in [[InsertIntoTable]] to V1 
[[FileFormat]].
    + * E.g, with temporary view `t` using [[FileDataSourceV2]], inserting into 
 view `t` fails
    + * since there is no correspoding physical plan.
    + * This is a temporary hack for making current data source V2 work.
    --- End diff --
    
    This is definitely temporary. We have to add this, otherwise we can't 
migrate file data sources to V2.
    I believe @cloud-fan have a plan for getting rid of this.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to