Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21187#discussion_r185260075
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -691,7 +691,9 @@ case class Pivot(
pivotColumn: Expression,
pivotValues: Seq[Literal],
aggregates: Seq[Expression],
- child: LogicalPlan) extends UnaryNode {
+ child: LogicalPlan,
+ groupByExprsImplicit: Boolean = false) extends UnaryNode {
+ override lazy val resolved = false // Pivot will be replaced after being
resolved.
--- End diff --
Could you add a negative test case to show which errors we could issue when
Pivot can't be resolved? If the error does not make sense to the end users, we
can improve the function `checkAnalysis` in the trait `CheckAnalysis`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
