Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21187#discussion_r185278754
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -691,7 +691,9 @@ case class Pivot(
pivotColumn: Expression,
pivotValues: Seq[Literal],
aggregates: Seq[Expression],
- child: LogicalPlan) extends UnaryNode {
+ child: LogicalPlan,
+ groupByExprsImplicit: Boolean = false) extends UnaryNode {
--- End diff --
Yes, I hesitated for a while... trying to figure out which way it would be
clearer, using `Option` or an extra flag. I did not have a preference, so I'll
do `Option` if you think it's better.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
